Skip to content

Geo type changes#2019

Closed
rambleraptor wants to merge 6 commits intoapache:mainfrom
rambleraptor:geo_type
Closed

Geo type changes#2019
rambleraptor wants to merge 6 commits intoapache:mainfrom
rambleraptor:geo_type

Conversation

@rambleraptor
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

What changes are included in this PR?

This gets the ball rolling with parsing the Geography + Geometry types. I'd love to hear any advice you might have!

Are these changes tested?

Unit tests are included.

@BlakeOrth
Copy link
Copy Markdown

hi @rambleraptor I came across this PR from the attached issue and am interested in helping this effort move forward. It looks like there are still some "todo" items in this implementation and it's not immediately clear to me if you're still working on this or are waiting on review etc.

I'd be happy to give a more thorough review against the spec if that's something you're needing to push forward on this. Otherwise, is there anything I can do to help move this along?

@brgr-s
Copy link
Copy Markdown

brgr-s commented Mar 4, 2026

@rambleraptor

I came across this PR because we wanted to implement geospatial columns for our fork of icebeg-rust (lakekeeper/lakekeeper#1579) that we are using in Lakekeeper. We already provided a PR for partial support of the VARIANT type (#2188)

I made some additions to your changes because I think there where Edge Interpolation Algorithms missing for the GEOGRAPHY type. Also I couldn't find the planar Edge Interpolaton Algorithm, at least in the parquet spec.

If you find those changes usefull you can find them here: https://github.com/brgr-s/iceberg-rust/tree/feat/geo-types-support

I think the biggest obstacle is that Spark 4.1 does not yet support geospatial types, so we can't integration test the feature at the moment.

@nuts-rice
Copy link
Copy Markdown

Would you mind if I fork this to add a geo types example?
#1826 was working on this

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants